Badge tracks whatever that last branch built
This is an issue if I update that gh-pages branch that is not build-able, it puts an erroneous failed badge on my github page.
Comments are currently closed for this discussion. You can start a new one.
Keyboard shortcuts
Generic
? | Show this help |
---|---|
ESC | Blurs the current field |
Comment Form
r | Focus the comment reply box |
---|---|
^ + ↩ | Submit the comment |
You can use Command ⌘
instead of Control ^
on Mac
Support Staff 1 Posted by Feodor Fitsner on 25 Feb, 2014 04:18 AM
Hi Jay,
You can use [skip ci] when committing changes to that branch (http://www.appveyor.com/docs2/how-to/skip-build).
Also, I think we should ignore "gh-pages" branch by default and also add branches filter to project settings.
Thanks for the catch! I'm going to add working item.
Support Staff 2 Posted by Feodor Fitsner on 25 Feb, 2014 04:26 AM
Wait, another idea. What if AppVeyor should display badge for
master
(default branch) only?3 Posted by Jay Tuley on 25 Feb, 2014 02:58 PM
Travis-ci actually makes a different badge url for each branch.
4 Posted by jay on 25 Feb, 2014 03:06 PM
Oh I do also think you should exclude gh-pages or just have a mechansim to exclude or explicitly specify branches. I don't want to do ci skip everytime on gh-pages.
Support Staff 5 Posted by Feodor Fitsner on 25 Feb, 2014 03:08 PM
Sure, we'll fix that shortly.
Thanks!
- Feodor
Support Staff 6 Posted by Feodor Fitsner on 26 Feb, 2014 05:27 AM
Hi Jay,
AppVeyor update has been deployed with improved badges logic.
To specify branch in badge URL append
/branch/<branch-name>
to the URL you see on Badges tab of project settings, for example:If branch IS specified badge shows the status of latest build of this branch; if branch IS NOT specified then badge shows the status of the last build of any branch.
Support Staff 7 Posted by Feodor Fitsner on 26 Feb, 2014 05:32 AM
Also, branches white-/blacklisting was added. You can specify included/excluded branches on General tab of project settings.
To specify the list of branches in
appveyor.yml
:To specify the list of branches that must be ignored:
gh-pages
branch is always excluded unless explicitly added in "only" list.8 Posted by jay on 27 Feb, 2014 02:19 PM
Cool, yay!
9 Posted by Sebastien on 15 May, 2014 04:49 AM
You should add a reference to this topic on the Badges page. This is very useful.
10 Posted by James Foster on 17 Jun, 2014 04:22 PM
Being able to specify a branch name for a status badge is great. However, I'm having some trouble with branches with a
/
in the name. for examplefeature/my-feature
Also, if I specify a branch that doesn't exist, instead of getting a 404 {message doesn't exist"} I get the status badge for the latest build.
Thanks
Support Staff 11 Posted by Feodor Fitsner on 17 Jun, 2014 04:34 PM
Have you tried encoding slash with
%2F
?12 Posted by James Foster on 17 Jun, 2014 07:14 PM
Yes
Sent from my iPhone
Support Staff 13 Posted by Feodor Fitsner on 17 Jun, 2014 07:15 PM
OK, will take a look what's wrong.
Support Staff 14 Posted by Feodor Fitsner on 17 Jun, 2014 07:26 PM
It's been fixed and will be go with the next update.
15 Posted by James Foster on 18 Jun, 2014 12:57 AM
That's great. Thanks
Support Staff 16 Posted by Feodor Fitsner on 18 Jun, 2014 04:01 AM
Update has been deployed. Should be OK now.
17 Posted by James Foster on 19 Jun, 2014 10:44 AM
Thanks Feodor
It's now picking up our feature branches correctly. However, if the branch name doesn't exist or isn't found it's still returning the default badge.
This really should return a 404 with some error status because going to
feature/i-think-it-exists
and seeing a shiny green success icon could be very confusing.Thanks
James
Support Staff 18 Posted by Feodor Fitsner on 19 Jun, 2014 02:27 PM
Will take a look.
- Feodor
Ilya Finkelshteyn closed this discussion on 25 Aug, 2018 01:45 AM.