CI Status Reporting as 'waiting' for commits that are skipped

Bryan Phelps's Avatar

Bryan Phelps

05 Jul, 2018 07:06 PM

Hello,

We recently switched our Oni appveyor account to an org account:
https://ci.appveyor.com/project/oni/oni/

We see an issue with the PR builds if our `skip_commits` criteria is triggered. We have a `skip _commits` rule that looks like this in our `appveyor.yml`:
```
# Skip CI build if the changes match these rules exactly.
# Ie, if the BACKERS.md file is changed, we don't need to build.
skip_commits:
  files:
    - '**/*.md'
```

And in that case, our PR build is stuck in 'waiting' - an example of this is here:
https://github.com/onivim/oni/pull/2402

I see these Events come through on our AppVeyor dashboard:
2018-07-05 10:30:54.313 Warning Commit "eb8b5e34" of branch "master" skipped as commit files matched "skip_commits.files"
2018-07-05 10:29:57.695 Warning Commit "38436289" skipped as branch "CrossR/ReadmeFix" is not in white-list
2018-07-05 10:15:23.336 Warning Commit "75fcdf7a" of branch "master" skipped as commit files matched "skip_commits.files"
2018-07-05 10:13:42.186 Warning Commit "c75a6ea1" skipped as branch "bryphe/appveyor/point-to-oni-org" is not in white-list

So it seems that the webhook is set up correctly, and it's getting the PR notification - and skipping it. Is there a way for us to have this report as 'Success' in the CI reporting for our pull requests?

  1. Support Staff 1 Posted by Ilya Finkelshte... on 05 Jul, 2018 07:25 PM

    Ilya Finkelshteyn's Avatar

    Hi Bryan,

    I posted related discussion in comments to your PR. It is very questionable, we honestly not sure what would be right behavior here. Ideally it would be some skipped or cancelled status which we asked GitHub to add few times already...

    Ilya.

Reply to this discussion

Internal reply

Formatting help / Preview (switch to plain text) No formatting (switch to Markdown)

Attaching KB article:

»

Already uploaded files

  • waiting.png 33.3 KB

Attached Files

You can attach files up to 10MB

If you don't have an account yet, we need to confirm you're human and not a machine trying to post spam.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac