tag:help.appveyor.com,2012-11-13:/discussions/problems/17913-github-appveyor-does-not-test-the-right-commitAppVeyor: Discussion 2019-06-23T21:01:05Ztag:help.appveyor.com,2012-11-13:Comment/464641972018-11-09T17:40:00Z2018-11-09T18:46:19ZGitHub: AppVeyor does not test the right commit<div><p>On a PR AppVeyor builds a virtual merge commit of the <strong>two</strong> commits shown. The head commit of the feature branch being merged into the head commit of the base branch.</p></div>Owen McDonnelltag:help.appveyor.com,2012-11-13:Comment/464641972018-11-09T17:49:17Z2018-11-09T18:46:19ZGitHub: AppVeyor does not test the right commit<div><p>I see, I was not aware of the merging.<br>
Still, it should then merge the actually shown commit into master. But at the<br>
point the job I showed ran, neither master nor the given commit had the new Rust<br>
version. Instead, it picked up commits that were added to the feature branch<br>
<em>after</em> the commit it shows in the job page. Effectively, the commit shown on the job page is useless information.<br>
FWIW, other CI services do not have this problem (Travis, for example).</p>
<p>On 09.11.18 18:40, Owen McDonnell wrote:</p></div>Ralf Jungtag:help.appveyor.com,2012-11-13:Comment/464641972019-04-16T19:25:51Z2019-04-16T19:25:52ZGitHub: AppVeyor does not test the right commit<div><blockquote>
<p>AppVeyor builds a virtual merge commit of the two commits shown.</p>
</blockquote>
<p>In fact I am pretty sure now that this is just not the case. Looking at <a href="https://ci.appveyor.com/project/rust-lang-libs/miri/builds/23897129/job/xt5ixv0893cgtv2e">https://ci.appveyor.com/project/rust-lang-libs/miri/builds/23897129...</a>, neither of the two commits shown at the top contained the change that lead to the build failure later.</p>
<p>This matches what one can see in the build script:</p>
<blockquote>
<p>git fetch -q origin +refs/pull/692/merge: git checkout -qf FETCH_HEAD</p>
</blockquote>
<p>It just picks whatever is the current state of the PR, entirely disregarding which commit it should be testing.</p>
<p>This can, obviously, lead to wrong results being reported, so it seems like quite a severe problem to me.</p></div>Ralf Jungtag:help.appveyor.com,2012-11-13:Comment/464641972019-04-23T13:33:34Z2019-04-23T13:33:34ZGitHub: AppVeyor does not test the right commit<div><p>Sorry for the delay in getting back to you.<br>
An <a href="https://github.com/appveyor/ci/issues/2920">issue</a> has been created.</p></div>Owen McDonnell