Return code of deploy hooks seems to be completely ignored

Paul Savoie's Avatar

Paul Savoie

27 Nov, 2018 11:03 AM

When calling a deployment web hook and the web hook returns a 400 or 500 HTTP error code, the deployment is still considered successful. Please fail the deployment in such cases and display an according error message.

I tested it by setting http://httpstat.us/400 and http://httpstat.us/500 as deploy hook URLs and the deployment step just says

Deploying using Webhook provider
Calling webhook http://httpstat.us/500...OK
Build success

Example build log: https://ci.appveyor.com/project/PaulSavoie/nugetdummylogger-swgqd/b...

  1. Support Staff 1 Posted by Ilya Finkelshte... on 27 Nov, 2018 04:05 PM

    Ilya Finkelshteyn's Avatar

    Thank you for the catch. Closing in favor of https://github.com/appveyor/ci/issues/2755

  2. Ilya Finkelshteyn closed this discussion on 27 Nov, 2018 04:05 PM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac