skip_commits.files does not work for files in .github folder

mloskot's Avatar

mloskot

21 Apr, 2022 09:10 PM

Here is my .appveyor.yml
https://github.com/nanodbc/nanodbc/blob/7f5bff212bcdcc1ec9b8068ffa9...

with the following section:

skip_commits:
  files:
    - '*file'
    - '*lint.*'
    - .github/**/*
    - doc/**/*
    - website/**/*

AFAICT, AppVeyor builds every commit that touches any file inside .github/ folder.

I'm wondering if any of this matters:

  • I use dot-appveyor.yml, not just appveyor.yml
  • perhaps .github/**/* pattern should read '.github/**/**'
  1. Support Staff 1 Posted by Feodor Fitsner on 22 Apr, 2022 03:04 PM

    Feodor Fitsner's Avatar

    .github/**/* is the correct pattern. Could you drop me a link to a build that passed that filter?

  2. 2 Posted by mloskot on 22 Apr, 2022 04:07 PM

    mloskot's Avatar

    Hmm, I think I have misinterpreted the problem, but there seem to be a problem:

    Commits with the filtered files touched that are pushed to the main branch are skipped, e.g. this one https://github.com/nanodbc/nanodbc/commit/324c415bde9b6f03e732aff5f...

    Commits pushed to a topic branch and submitted via pull request are also skipped, e.g. no build at https://ci.appveyor.com/project/nanodbc/nanodbc/history for https://github.com/nanodbc/nanodbc/pull/316 and there also is 'skipped' event the 'virtual' Merge 04cca09 into 324c415 commit for the PR https://github.com/nanodbc/nanodbc/commit/f6a7ba31

    But, for some reason, the GitHub PR checks status is not being updated correctly and is hanging with

    continuous-integration/appveyor/pr Expected — Waiting for status to be reported
    
  3. 3 Posted by mloskot on 27 Apr, 2022 02:14 PM

    mloskot's Avatar

    @Feodor, did my update to the issue help? Would you have any news on that?

Reply to this discussion

Internal reply

Formatting help / Preview (switch to plain text) No formatting (switch to Markdown)

Attaching KB article:

»

Attached Files

You can attach files up to 10MB

If you don't have an account yet, we need to confirm you're human and not a machine trying to post spam.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac