Pull request status on Github shows three appveyor status, first one stays on "yellow" forever

Marcel Stimberg's Avatar

Marcel Stimberg

20 Nov, 2015 05:31 PM

We've been using appveyor for Windows testing quite a while (thanks for this great service, by the way!) and we always had two statuses displayed on each pull request ("branch" and "pr"). Recently, a third status that seems to be some kind of summary status (just "continuous-integration/appveyor") has been added, but this one stays at "Waiting for status to be reported" even after the branch and pr jobs successfully ran. This is not a huge problem, as all the information about build success/failure is visible in the pull request, but it leads to a never-changing "yellow" status in the pull request overview. Here's an example of a pull request currently showing this behaviour: https://github.com/brian-team/brian2/pull/588

Thanks in advance!

  1. 1 Posted by Marcel Stimberg on 20 Nov, 2015 05:37 PM

    Marcel Stimberg's Avatar

    I just saw that http://help.appveyor.com/discussions/problems/3612-github-showing-m... seems to be about the same problem. Our case is slightly different, though, we do have "branch protection" for the master branch but we did not activate the "Require status checks to pass before merging" option.

  2. Support Staff 2 Posted by Feodor Fitsner on 20 Nov, 2015 05:55 PM

    Feodor Fitsner's Avatar

    Well, it's not quite like that. There was only one continuous-integration/appveyor status before and two separate statuses were introduced instead: continuous-integration/appveyor/branch and continuous-integration/appveyor/pr. Edit protected branch settings to check continuous-integration/appveyor/pr only.

  3. 3 Posted by Marcel Stimberg on 20 Nov, 2015 07:02 PM

    Marcel Stimberg's Avatar

    Thanks for the quick reply. I did indeed mix up things, I guess I was thinking about travis which had two separate statuses before. Either way, unfortunately I cannot apply your advice since while we protect the master branch, we do not have the "Require status checks to pass before merging" enabled (see screenshot).

  4. Support Staff 4 Posted by Feodor Fitsner on 20 Nov, 2015 07:05 PM

    Feodor Fitsner's Avatar

    Oh, seems like new statuses were introduced in the middle of the build?

    If you can tell what commit it was then you can use GitHub API to remote that status from the commit. Or maybe it's better go through all PR commits in a loop and check their statuses.

  5. 5 Posted by Marcel Stimberg on 26 Nov, 2015 05:12 PM

    Marcel Stimberg's Avatar

    Oh, seems like new statuses were introduced in the middle of the build?

    That doesn't seem to be the reason, we are getting it for each new pull request, e.g. this one opened two days ago: https://github.com/brian-team/brian2/pull/600

    If it is the only solution for now, enabling "require status checks to pass before merging" wouldn't be a big deal, though...

  6. Support Staff 6 Posted by Feodor Fitsner on 26 Nov, 2015 05:29 PM

    Feodor Fitsner's Avatar

    Yes, you should update protected branches - give it a try.

  7. 7 Posted by Marcel Stimberg on 26 Nov, 2015 05:41 PM

    Marcel Stimberg's Avatar

    Ok, I did it -- all is looking good now. Thanks again for your help!

  8. Marcel Stimberg closed this discussion on 26 Nov, 2015 05:41 PM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac