on 21 Mar, 2017 10:38 AM
Sorry, that was indeed a bit confusing... I've looked closely at our build results once more:
Main cause for failing builds is the test that checks whether our adapter's SettingsProvider has been registered successfully. This is very comparable to the test which used to fail last time and got fixed by your patch. However, this happens also on VS2015 (although mostly on VS2017) Builds: 710, 709, 706, 705, 697, 683
Some builds are failing due to a failed timing test (I suspect that this happens if the build machine we are running on is rather busy - probably not much we can do about that despite increasing the test's timing tolerance)
weird AccessViolationException exception on VS 2017 as described above (build 710)
last good build was (after a couple of failed builds) build 711 (same commit as 706, 708-710)
Thus, it looks like nothing has changed from your side - sorry for wasting your time. We still have no idea why our SettingsProvider test currently fails regularly (and this never happens on our local machines), but it's not a very new problem.
If we get more AccessViolationExceptions, I'll let you know.
Sure, is there anything we could (should) do on VS 2017 to make your tests work please let us know. Also, looking via RDP into build worker could help you troubleshoot many issues - RDP works for VS 2017 image now.