skip_branch_with_pr setting doesn't work?

Antti Pihlaja's Avatar

Antti Pihlaja

17 Mar, 2018 04:01 PM

# Do not build feature branch with open Pull Requests
skip_branch_with_pr: true

That doesn't work, does it? At least doesn't work in my repo, the history is full of duplicate builds: https://ci.appveyor.com/project/apihlaja/node-irsdk/history

  1. Support Staff 1 Posted by Ilya Finkelshte... on 17 Mar, 2018 07:16 PM

    Ilya Finkelshteyn's Avatar

    It works. What you see is expected behavior because you initially create commit to the feature branch, and only after that pull request is being created.

    After commit to the feature branch is created, push webhook is being immediately
    fired and AppVeyor do not see if PR is created from that branch, because it is still not actually created. This sequence is true even if you use Create a new branch for this commit and start a pull request. in GutHub. All subsequent commits to that branch will be silenced until PR merged or closed.

    If you do not need builds for even initial commit to the feature branch, you can use branch filtering or uncheck Push in AppVeyor webhook settings on GitHub.

  2. 2 Posted by Jan Pio on 20 Mar, 2018 05:20 PM

    Jan Pio's Avatar

    Oh.

    You might want to change the option explanation to "Do not build feature branch on additional commits with open Pull Requests" to make this more clear.

  3. Support Staff 3 Posted by Ilya Finkelshte... on 21 Mar, 2018 01:56 AM

    Ilya Finkelshteyn's Avatar

    Yes, we will not rename but add tooltip. This question is becoming pretty often.

  4. 4 Posted by Jan Pio on 21 Mar, 2018 02:05 PM

    Jan Pio's Avatar

    Nice.

    (I think what I copy pasted and modified is the comment in the appveyor.yml reference file - that couuld be changed as well)

Reply to this discussion

Internal reply

Formatting help / Preview (switch to plain text) No formatting (switch to Markdown)

Attaching KB article:

»

Attached Files

You can attach files up to 10MB

If you don't have an account yet, we need to confirm you're human and not a machine trying to post spam.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac