Build not showing all commits

Scott Dorman's Avatar

Scott Dorman

06 Aug, 2014 09:02 PM

I pushed two commits to my GitHub repository, one right after another. AppVeyor properly saw that the repo had changed and queued up a build, however the build history only shows the last commit. I would have expected both of the commits to be shown.

The build in question is https://ci.appveyor.com/project/scottdorman/codestyle-co/build/1.0.18. This shows only the last commit (https://github.com/scottdorman/codestyle.co/commit/54670891a70c4cd5f390c90e717777ae06c9dd0a) but it should also show this one as well (https://github.com/scottdorman/codestyle.co/commit/964cbd24a274fc8dcf84ae22b3ab95375650dd98).

  1. Support Staff 1 Posted by Feodor Fitsner on 07 Aug, 2014 01:28 AM

    Feodor Fitsner's Avatar

    Hi Scott,

    If you open project webhook settings on GitHub and see the history of its calls do you see any failed responses?

  2. 2 Posted by Scott Dorman on 07 Aug, 2014 03:27 AM

    Scott Dorman's Avatar

    No, all of the responses are successful. I did push the commits right after each other. The time stamps are 4:52 PM and 4:53 PM, although they are probably really only seconds apart.

  3. Support Staff 3 Posted by Feodor Fitsner on 07 Aug, 2014 12:56 PM

    Feodor Fitsner's Avatar

    OK, what's in response for the missing one? Is it just 204 no content?

  4. 4 Posted by Scott Dorman on 07 Aug, 2014 01:51 PM

    Scott Dorman's Avatar

    Yes, the response is just 204 with no body content. The request information looks like this:

    Headers:
    Request URL: https://ci.appveyor.com/api/github/webhook?id=x8ngr9nk24yucl0p
    Request method: POST
    content-type: application/x-www-form-urlencoded
    Expect:
    User-Agent: GitHub-Hookshot/eddbeea
    X-GitHub-Delivery: b2c2098c-1dab-11e4-9760-d42818958063
    X-GitHub-Event: push

    Payload (trimmed):
    {
      "ref": "refs/heads/master",
      "after": "54670891a70c4cd5f390c90e717777ae06c9dd0a",
      "before": "3a2b879d32b8d6a185efe27e54f543f90fa40362",
      "created": false,
      "deleted": false,
      "forced": false,
      "compare": "https://github.com/scottdorman/codestyle.co/compare/3a2b879d32b8...54670891a70c",
      "commits": [
        {
          "id": "964cbd24a274fc8dcf84ae22b3ab95375650dd98",
          "distinct": true,
          "message": "Fixed some non-printing characters.",
          "timestamp": "2014-08-06T16:52:49-04:00",
          "url": "https://github.com/scottdorman/codestyle.co/commit/964cbd24a274fc8dcf84ae22b3ab95375650dd98",
          "author": {
            "name": "Scott Dorman",
            "email": "",
            "username": ""
          },
          "committer": {
            "name": "Scott Dorman",
            "email": "",
            "username": ""
          },
          "added": [

          ],
          "removed": [

          ],
          "modified": [
            "data/css/nesting.md"
          ]
        },
        {
          "id": "54670891a70c4cd5f390c90e717777ae06c9dd0a",
          "distinct": true,
          "message": "Added AngularJS guidelines.",
          "timestamp": "2014-08-06T16:53:07-04:00",
          "url": "https://github.com/scottdorman/codestyle.co/commit/54670891a70c4cd5f390c90e717777ae06c9dd0a",
          "author": {
            "name": "Scott Dorman",
            "email": "",
            "username": ""
          },
          "committer": {
            "name": "Scott Dorman",
            "email": "",
            "username": ""
          },
          "added": [
            "data/angularjs/angular-$-wrapper-services.md",
            "data/angularjs/application-structure.md",
            "data/angularjs/comments.md",
            "data/angularjs/constants.md",
            "data/angularjs/contents.json",
            "data/angularjs/controllers.md",
            "data/angularjs/directives.md",
            "data/angularjs/exception-handling.md",
            "data/angularjs/factories.md",
            "data/angularjs/iife.md",
            "data/angularjs/js-hint.md",
            "data/angularjs/manual-dependency-injection.md",
            "data/angularjs/minification-and-annotation.md",
            "data/angularjs/modules.md",
            "data/angularjs/resolving-promises-for-a-controller.md",
            "data/angularjs/services.md",
            "data/angularjs/single-responsibility.md"
          ],
          "removed": [

          ],
          "modified": [

          ]
        }
      ],
      "head_commit": {
        "id": "54670891a70c4cd5f390c90e717777ae06c9dd0a",
        "distinct": true,
        "message": "Added AngularJS guidelines.",
        "timestamp": "2014-08-06T16:53:07-04:00",
        "url": "https://github.com/scottdorman/codestyle.co/commit/54670891a70c4cd5f390c90e717777ae06c9dd0a",
        "author": {
          "name": "Scott Dorman",
          "email": "",
          "username": ""
        },
        "committer": {
          "name": "Scott Dorman",
          "email": "",
          "username": ""
        },
        "added": [
          "data/angularjs/angular-$-wrapper-services.md",
          "data/angularjs/application-structure.md",
          "data/angularjs/comments.md",
          "data/angularjs/constants.md",
          "data/angularjs/contents.json",
          "data/angularjs/controllers.md",
          "data/angularjs/directives.md",
          "data/angularjs/exception-handling.md",
          "data/angularjs/factories.md",
          "data/angularjs/iife.md",
          "data/angularjs/js-hint.md",
          "data/angularjs/manual-dependency-injection.md",
          "data/angularjs/minification-and-annotation.md",
          "data/angularjs/modules.md",
          "data/angularjs/resolving-promises-for-a-controller.md",
          "data/angularjs/services.md",
          "data/angularjs/single-responsibility.md"
        ],
        "removed": [

        ],
        "modified": [

        ]
      },
      "repository": {
        "id": 22123271,
        "name": "codestyle.co",
        "full_name": "scottdorman/codestyle.co",
        "owner": {
          "name": "scottdorman",
          "email": "[email blocked]"
        },
        "private": false,
        "html_url": "https://github.com/scottdorman/codestyle.co",
        "description": "Markdown files for code style guidelines on",
        "fork": false,
        "url": "https://github.com/scottdorman/codestyle.co",
        "default_branch": "master",
        "stargazers": 16,
        "master_branch": "master"
      },
      "pusher": {
        "name": "scottdorman",
        "email": "[email blocked]"
      }
    }

  5. Support Staff 5 Posted by Feodor Fitsner on 07 Aug, 2014 02:10 PM

    Feodor Fitsner's Avatar

    OK, I see. There was a push with two commits, right? AppVeyor builds not all but the latest one ("head_commit" in webhook payload).

  6. 6 Posted by Scott Dorman on 07 Aug, 2014 02:49 PM

    Scott Dorman's Avatar

    Yes, that's exactly right. It was a single push with two commits. What would be nice in a scenario like this is to still build just the "head_commit", but display the commit information for all of the commits that were in the payload.

    That way when you look at the build you see all of the changes that went into that build and not just the latest one. I guess it's more of a display issue than a change in what it being built.

  7. Support Staff 7 Posted by Feodor Fitsner on 07 Aug, 2014 02:52 PM

    Feodor Fitsner's Avatar

    Ah, OK then. Will add an item for that.

  8. 8 Posted by Scott Dorman on 07 Aug, 2014 02:54 PM

    Scott Dorman's Avatar

    Thanks! I know it's a might seem like a small thing, but I think it's really important for the build history to show all of the commits that went into a specific build.

  9. Ilya Finkelshteyn closed this discussion on 25 Aug, 2018 01:46 AM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac

 

01 Oct, 2024 04:27 PM
26 Sep, 2024 03:49 PM
26 Sep, 2024 09:02 AM
25 Sep, 2024 07:07 PM
24 Sep, 2024 08:39 PM
24 Sep, 2024 06:47 AM