Test the merge in a build initiated by a pull request

Diogo Mafra's Avatar

Diogo Mafra

22 Jan, 2015 08:39 PM

Are builds initiated by "pull requests" merged before the build? It looks like they aren't.

In others build systems, the build is done using the result of the merge between origin and the upstream branch.

  1. Support Staff 1 Posted by Feodor Fitsner on 22 Jan, 2015 09:06 PM

    Feodor Fitsner's Avatar

    Yeah, AppVeyor fetches virtual merge commit created by GitHub and you should see these two additional commands in the build log:

    git fetch -q origin +refs/pull/{number}/merge:
    git checkout -qf FETCH_HEAD
    
  2. 2 Posted by Diogo Mafra on 23 Jan, 2015 11:58 AM

    Diogo Mafra's Avatar

    Right, I see this command in the logs.

    But, in a pull request that can't be automatically merged, it built using the commit ("git checkout -qf xyz123..."). Is this the expected thing? I thought the build would fail, as it can't merge the source.

  3. Support Staff 3 Posted by Feodor Fitsner on 23 Jan, 2015 02:45 PM

    Feodor Fitsner's Avatar

    No, it's not expected. Are you sure it was triggered by PR webhook event? You may check "Recent deliveries" of project webhook in GitHub to see what was request and AV response. Also send me AV project name and build version to check in database.

    Yesterday we deployed an update that should reliably prevent starting builds for non-mergeable PRs.

    -Feodor

  4. 4 Posted by Diogo Mafra on 23 Jan, 2015 03:10 PM

    Diogo Mafra's Avatar

    Looks like this update corrected the problem. Now it is working as expected.

    Thank you.

  5. Support Staff 5 Posted by Feodor Fitsner on 23 Jan, 2015 03:11 PM

    Feodor Fitsner's Avatar

    Great, thanks for the update!

    -Feodor

  6. Ilya Finkelshteyn closed this discussion on 25 Aug, 2018 01:53 AM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac

Recent Discussions

20 Mar, 2019 11:39 PM
20 Mar, 2019 09:03 PM
20 Mar, 2019 08:55 PM
20 Mar, 2019 08:48 PM
20 Mar, 2019 08:02 PM

 

20 Mar, 2019 07:14 PM
20 Mar, 2019 06:27 PM
20 Mar, 2019 04:02 PM
20 Mar, 2019 08:51 AM
19 Mar, 2019 06:21 PM
19 Mar, 2019 05:22 PM