want skip_pr_with_branch: true

Jay Tuley's Avatar

Jay Tuley

11 Aug, 2017 10:03 PM

I want the opposite of skip_branch_with_pr: true.

or maybe a skip_branch_with_pr: pr

Basically I only want want thing to build when I have a feature branch and a pull request. But I want my deploy tasks to work, so I want it to skip the PR rather than the branch.

I've been struggle to get there workflow just right, and I finally have except for this one thing, either allow two builds when I have a pull request on my branch, or can't deploy to me myget feed.

https://github.com/jbtule/keyczar-dotnet/blob/4f355407d444a5cadbb2ea3d81dc2be725cfd55e/.appveyor.yml#L10

Thanks,

  1. 1 Posted by Ilya Finkelshte... on 11 Aug, 2017 10:57 PM

    Ilya Finkelshteyn's Avatar

    You can go to Settings > Webhooks for your repo on GitHub, select AppVeyor webhook and uncheck Pull request. If this does not work for you, please describe your scenario in more details.

  2. 2 Posted by Jay Tuley on 14 Aug, 2017 07:11 PM

    Jay Tuley's Avatar

    Yeah that doesn't work.

     I still want pull requests from repo forks to still build, just not deploy, the normal PR behavior that doesn't need skipping.

    What I'm asking for is that I want pull requests from a branch on my repo to build the branch and skip PR so it does the branch behavior which includes deploy, but I don't want it to build twice, hence why I want basically the skip the PR rather than vice versa.

  3. 3 Posted by Ilya Finkelshte... on 15 Aug, 2017 02:00 AM

    Ilya Finkelshteyn's Avatar

    Sorry but I still believe that this should work for your scenario... If you uncheck Pull request in Webhook settings, this does not prevent Webhooks triggered by push. Anytime you create pull request, you do normal commit to the feature branch as well, right? So push webhook should be triggered OK and build for feature branch should be started. If you need separate deployment settings for the feature branch, you can do conditional deployment. And again with Pull request unchecked, PR build for the master branch will not be started, so nothing will be built twice.

  4. 4 Posted by Jay Tuley on 15 Aug, 2017 03:48 PM

    Jay Tuley's Avatar

    Yes, but what you suggest also means 0 builds from PRs from third parties. I want 1 build for me that deploys and 1 one build from third parties that does not deploy.

    current config options:

    • normal -- build & test for me:2 , deploys:yes, build & tests for others:1
    • skip_branch_with_pr:true -- build & test for me:1, deploys:no, build & tests for others:1
    • disable pr hook -- build & test for me:1, deploys:yes, build & tests for others:0
  5. Ilya Finkelshteyn closed this discussion on 25 Aug, 2018 02:19 AM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac