[skip ci] doesn't work as expected

Daniele Varrazzo's Avatar

Daniele Varrazzo

Jan 29, 2018 @ 01:15 PM

Using [skip ci] in the body of a comment doesn't work with appveyor as it works for other CI systems such as Travis or GitLab CI.

Example: https://ci.appveyor.com/project/psycopg/psycopg2/build/2.x.314

I read from the docs that [skip ci] is only parsed in the title "to avoid confusion": sorry but this is nonsense. If someone squashes commits they can well take a look at the message they are pushing. The title of a commit is a resource too important to be littered with close #123, [skip ci] or other transient stuff. It is used to generate logs; displayed in interface; some policies suggest keeping it under 50 chars... (TBH for me it's also questionable if the commit message too is worth being littered, but git doesn't offer anything else I suppose).

I suggest you to review your policy and allow [skip ci] anywhere in the commit message, to uniform it to other build systems.

  1. 1 Posted by Ilya Finkelshte... on Jan 29, 2018 @ 05:22 PM

    Ilya Finkelshteyn's Avatar

    You are right, we will review it, please watch this GitHub issue. Sorry for confusion :)

  2. Ilya Finkelshteyn closed this discussion on Aug 25, 2018 @ 02:26 AM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac