Builds failing due to GitHub TLS changes

This discussion is public.

ryan's Avatar

ryan

22 Feb, 2018 09:05 PM

All of our builds just started failing on the Visual Studio 2017 template due to the recent GitHub TLS changes.

The request was aborted: Could not create SSL/TLS secure channel. (Github - cached (temporarily ignore updates))
Error executing: paket.exe config

  1. 1 ryan's Avatar ryan on 22 Feb, 2018 09:06 PM

  2. Support Staff 2 Feodor Fitsner's Avatar Feodor Fitsner on 22 Feb, 2018 10:01 PM

    Hi Ryan,

    Adding these commands to the build should fix the issue: https://github.com/fsprojects/Paket/issues/3065#issuecomment-367829309

    init:
    - ps: new-itemproperty -path "HKLM:\SOFTWARE\Microsoft\.NETFramework\v4.0.30319" -name "SchUseStrongCrypto" -Value 1 -PropertyType "DWord";
    - ps: new-itemproperty -path "HKLM:\SOFTWARE\Wow6432Node\Microsoft\.NETFramework\v4.0.30319" -name "SchUseStrongCrypto" -Value 1 -PropertyType "DWord"
    

    We've made sure all AppVeyor components (Web API, workers services, agents, etc.) are working with TLS 1.2, however didn't apply the fix above globally to all images to get some preliminary feedback from customers.

    Btw, another solution specific to paket could be adding app.config next to the executable and requiring .NET 4.6. .NET 4.6 has strong ciphers enabled by default.

  3. 3 ryan's Avatar ryan on 23 Feb, 2018 05:36 AM

    That worked, thanks!

  4. 4 kode54's Avatar kode54 on 17 Mar, 2018 09:05 PM

    New issue stemming from this. Now that the fix appears to be integrated, it broke my configurations due to:

    new-itemproperty : The property already exists.
    At line:1 char:1
    + new-itemproperty -path "HKLM:\SOFTWARE\Microsoft\.NETFramework\v4.0.3 ...
    + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        + CategoryInfo          : ResourceExists: (HKEY_LOCAL_MACH...work\v4.0.30319:String) [New-ItemProperty], IOException
        + FullyQualifiedErrorId : System.IO.IOException,Microsoft.PowerShell.Commands.NewItemPropertyCommand
     
    Command executed with exception: The property already exists.
    

    I guess I can remove that from my appveyor configuration now.

  5. 5 Ilya Finkelshteyn's Avatar Ilya Finkelshteyn on 19 Mar, 2018 04:35 AM

    Yes, just remove the workaround.

  6. ryan closed this discussion on 11 Apr, 2018 04:01 PM.

Comments are currently closed for this discussion. You can start a new one.