Consider setting APPVEYOR_REPO_COMMIT_MESSAGE_EXTENDED to an empty string, if it doesn't exist.

teo.tsirpanis.718's Avatar

teo.tsirpanis.718

20 May, 2019 08:58 PM

If the message of a commit is only one line long, the environment variable APPVEYOR_REPO_COMMIT_MESSAGE_EXTENDED does not exist. This meant that FAKE's AppVeyor library returned null, which crashes the build script if it is used improperly.

This was discovered to be the cause of a previously unresolved bug on a project of mine. As a workaround, the value is checked for null on my build script.

Given that environment variables represent important configuration data, that there is no other variable that may not exist, and that AppVeyor's documentation on environment variables mentions in the beginning "[e]nvironment variables that are set by AppVeyor for every build", my proposal is to always define the APPVEYOR_REPO_COMMIT_MESSAGE_EXTENDED variable, setting it to an empty string by default.

If it is not possible, I will take care to fix FAKE accordingly.

  1. 1 Posted by Owen McDonnell on 21 May, 2019 05:32 PM

    Owen McDonnell's Avatar

    Thanks for bringing this to our attention.

    An issue has been created here

  2. Ilya Finkelshteyn closed this discussion on 21 Jul, 2019 09:01 PM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac

Recent Discussions

07 Jul, 2020 06:21 PM
07 Jul, 2020 03:15 PM
05 Jul, 2020 02:33 AM
03 Jul, 2020 07:29 PM
03 Jul, 2020 03:53 AM

 

02 Jul, 2020 09:09 PM
02 Jul, 2020 03:24 PM
01 Jul, 2020 01:12 PM
30 Jun, 2020 04:26 PM
25 Jun, 2020 05:54 PM
24 Jun, 2020 08:11 AM