Run test before merge PR
Hi,
We have sometime the following situation:
We have two branches with impact on the tests from each other. Both test sequences in PR passed successfully.
The first PR is merged, no problem. The second one is merged, some tests fail because the results are not the same anymore. Nothing was indicated since there was no conflicts. Therefore, we had to create a new PR or fix the tests in develop.
It would be helpful if it was possible to build and run tests before actually merging a pull request instead of the other way on merge action, so we could make the changes in the same PR. Is it possible to do that?
Comments are currently closed for this discussion. You can start a new one.
Keyboard shortcuts
Generic
| ? | Show this help |
|---|---|
| ESC | Blurs the current field |
Comment Form
| r | Focus the comment reply box |
|---|---|
| ^ + ↩ | Submit the comment |
You can use Command ⌘ instead of Control ^ on Mac
Support Staff 1 Posted by Owen McDonnell on 23 Jul, 2019 02:40 PM
If i understand correctly, you want to trigger a build from within a build, correct?
If so, you could make an API call from
on_success:config section.2 Posted by Maxime Ball on 23 Jul, 2019 02:58 PM
That’s not really what I want to do, sorry for the lack of clarity.
After starting a merge of a PR on GitHub, I want to abort the merge if the tests have failed.
Support Staff 3 Posted by Owen McDonnell on 25 Jul, 2019 03:42 PM
After the first branch is merged you can go to the other branches "virtual merge" build and hit
RE-BUILD PRbutton. This will expose any new test errors due to previous merge.Ilya Finkelshteyn closed this discussion on 24 Sep, 2019 09:01 PM.