PRs merged before build started should not report broken status

Lamont Granquist's Avatar

Lamont Granquist

21 Nov, 2015 12:41 AM

This change:

Broke behavior that I used to like which is that I could rebase and push and merge a PR before the build was done and the build would run "asynchronously" and I'd stll get notification if something went badly. Now it just cancels the build and always shows up as an angry red cross on github.

And I do this because I need to edit a file which is shared and which constantly produces merge conflicts as people merge commits to it. So pushing the rebase and waiting 30-60 minutes for the build to complete can often result in a merge conflict and a need to re-rebase it and push it again, and wait again.

I can understand the original intent of the request to avoid running builds on closed PRs (that's useless). I'm not sure it makes sense to also cancel builds on merged PRs (since if something does go wrong on the merged PR it'd still be useful to get notification about that after-the-fact even if you didn't get it before-the-fact). Its also just annoying because all my PRs look red all the time, and at the very least I'd like the ability to set the old behavior.

  1. Support Staff 1 Posted by Feodor Fitsner on 23 Nov, 2015 04:20 AM

    Feodor Fitsner's Avatar

    Looks like we need another project setting! Something like Do not build closed PRs (feel free to suggest a better wording) and by default it won't be enabled. Right?

  2. 2 Posted by Lamont Granquis... on 23 Nov, 2015 08:46 AM

    Lamont Granquist's Avatar

    Yeah, I don't know that I care what the default setting is. Since not a
    lot of people seem to have found my ticket, maybe the default should be
    the way it is now. Your wording seems fine to me.

  3. Support Staff 3 Posted by Feodor Fitsner on 28 Nov, 2015 04:49 AM

    Feodor Fitsner's Avatar

    A new option "Always build closed pull requests" has been added to General tab of project settings.

  4. Ilya Finkelshteyn closed this discussion on 25 Aug, 2018 02:02 AM.

Comments are currently closed for this discussion. You can start a new one.

Keyboard shortcuts


? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac